Skip to content

[Refactor] Simplify collectLog#7581

Draft
gonzaloriestra wants to merge 1 commit into
mainfrom
jules-refactor-simplify-collect-log-12361544096002401665
Draft

[Refactor] Simplify collectLog#7581
gonzaloriestra wants to merge 1 commit into
mainfrom
jules-refactor-simplify-collect-log-12361544096002401665

Conversation

@gonzaloriestra
Copy link
Copy Markdown
Contributor

WHY are these changes introduced?

Improve readability and maintainability by using modern TypeScript patterns and reducing redundant operations in the collectLog utility.

WHAT is this pull request doing?

Refactors collectLog in packages/cli-kit/src/public/node/output.ts to:

  • Use the nullish coalescing assignment operator (??=) for initializing log arrays.
  • Extract the stringification and ANSI stripping of the message to a variable to avoid redundant work.
  • Remove a redundant nullish coalescing check on stringifyMessage.

How to test your changes?

CI

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes
  • I've considered analytics changes to measure impact
  • The change is user-facing — I've identified the correct bump type (patch for bug fixes · minor for new features · major for breaking changes) and added a changeset with pnpm changeset add

PR created automatically by Jules for task 12361544096002401665 started by @gonzaloriestra

Refactor `collectLog` in `packages/cli-kit/src/public/node/output.ts` to improve readability and avoid redundant operations.

Changes:
- Use nullish coalescing assignment (`??=`) for log array initialization.
- Extract `stripAnsi(stringifyMessage(content))` into a single constant to avoid repeated execution.
- Remove redundant `?? ''` on `stringifyMessage` as it always returns a string.
@google-labs-jules
Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@github-actions github-actions Bot added the no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users. label May 19, 2026
@gonzaloriestra gonzaloriestra added the Jules Created by Jules label May 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Jules Created by Jules no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant