[Refactor] Simplify collectLog#7581
Conversation
Refactor `collectLog` in `packages/cli-kit/src/public/node/output.ts` to improve readability and avoid redundant operations. Changes: - Use nullish coalescing assignment (`??=`) for log array initialization. - Extract `stripAnsi(stringifyMessage(content))` into a single constant to avoid repeated execution. - Remove redundant `?? ''` on `stringifyMessage` as it always returns a string.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
WHY are these changes introduced?
Improve readability and maintainability by using modern TypeScript patterns and reducing redundant operations in the
collectLogutility.WHAT is this pull request doing?
Refactors
collectLoginpackages/cli-kit/src/public/node/output.tsto:??=) for initializing log arrays.stringifyMessage.How to test your changes?
CI
Checklist
patchfor bug fixes ·minorfor new features ·majorfor breaking changes) and added a changeset withpnpm changeset addPR created automatically by Jules for task 12361544096002401665 started by @gonzaloriestra