Skip to content

chore: enforce pnpm 11#1170

Open
Sheraff wants to merge 1 commit into
TanStack:mainfrom
Sheraff:opencode/enforce-pnpm-11
Open

chore: enforce pnpm 11#1170
Sheraff wants to merge 1 commit into
TanStack:mainfrom
Sheraff:opencode/enforce-pnpm-11

Conversation

@Sheraff
Copy link
Copy Markdown
Contributor

@Sheraff Sheraff commented May 21, 2026

Adds engines.pnpm >=11.0.0 to TanStack/virtual.

Scenario Result
pnpm@11+ install Allowed
pnpm@11+ run ... Allowed
pnpm@9 install Blocked by engines.pnpm
pnpm@9 run ... Blocked by engines.pnpm
pnpm@10 install with default pnpm version management Usually hands off to packageManager and runs as the declared pnpm version
pnpm@10 run ... with default pnpm version management Usually hands off to packageManager and runs as the declared pnpm version
pnpm@10 install with version handoff disabled Blocked by engines.pnpm
pnpm@10 run ... with version handoff disabled Blocked by engines.pnpm
pnpm@9/10 list Not blocked
pnpm@9/10 exec ... Not blocked
Field What It Does
packageManager Helps tools/newer pnpm select or hand off to the declared pnpm version
engines.pnpm: ">=11.0.0" Fails important project workflows when an older pnpm is actually executing them
engines.pnpm Does not intercept every pnpm subcommand

Summary by CodeRabbit

  • Chores
    • Updated the pnpm package manager version requirement to 11.0.0 or higher.

Review Change Stack

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 21, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: e46e05cf-e1b9-40d4-9b0b-13e05eca37bd

📥 Commits

Reviewing files that changed from the base of the PR and between 949180b and 284680f.

📒 Files selected for processing (1)
  • package.json

📝 Walkthrough

Walkthrough

This PR adds a pnpm version constraint to the project configuration, specifying that pnpm 11.0.0 or higher is required to work with this project.

Changes

pnpm version requirement

Layer / File(s) Summary
pnpm engine version constraint
package.json
Added engines.pnpm field specifying minimum pnpm version as >=11.0.0.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A carrot for consistency!
Pnpm eleven or bust, we say—
Version gates keep chaos at bay.
Hop, confirm, and away we go! 🌟

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive The description provides detailed context about the engines.pnpm constraint, but is missing required template sections including the checklist items and release impact declaration. Complete the PR description by adding the checklist section and release impact section from the template to indicate whether testing was performed and if a changeset is needed.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title 'chore: enforce pnpm 11' clearly and concisely summarizes the main change: adding a pnpm version enforcement constraint to package.json.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@nx-cloud
Copy link
Copy Markdown

nx-cloud Bot commented May 21, 2026

View your CI Pipeline Execution ↗ for commit 284680f

Command Status Duration Result
nx affected --targets=test:sherif,test:knip,tes... ✅ Succeeded 2m 21s View ↗
nx run-many --target=build --exclude=examples/** ✅ Succeeded 18s View ↗

☁️ Nx Cloud last updated this comment at 2026-05-21 21:12:04 UTC

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented May 21, 2026

More templates

@tanstack/angular-virtual

npm i https://pkg.pr.new/@tanstack/angular-virtual@1170

@tanstack/lit-virtual

npm i https://pkg.pr.new/@tanstack/lit-virtual@1170

@tanstack/react-virtual

npm i https://pkg.pr.new/@tanstack/react-virtual@1170

@tanstack/solid-virtual

npm i https://pkg.pr.new/@tanstack/solid-virtual@1170

@tanstack/svelte-virtual

npm i https://pkg.pr.new/@tanstack/svelte-virtual@1170

@tanstack/virtual-core

npm i https://pkg.pr.new/@tanstack/virtual-core@1170

@tanstack/vue-virtual

npm i https://pkg.pr.new/@tanstack/vue-virtual@1170

commit: 284680f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant