Sync DefaultTypeProvider and dependency-types docs across impl and compat#12134
Open
gnodet wants to merge 1 commit into
Open
Sync DefaultTypeProvider and dependency-types docs across impl and compat#12134gnodet wants to merge 1 commit into
gnodet wants to merge 1 commit into
Conversation
The two DefaultTypeProvider copies (impl/maven-impl and compat/maven-resolver-provider) had drifted out of sync: - fatjar type was missing from the impl provider - test-java-source type was missing from the compat provider - CLASSPATH_PROCESSOR and MODULAR_PROCESSOR ordering was inconsistent Both dependency-types.apt files also had copy-paste errors from the test-jar row (bogus "tests" classifier on modular-jar, classpath-jar, and fatjar) and were missing fatjar's includesDependencies=true flag. Added the missing processor types and test-java-source to both docs. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Syncs Maven 4 “default dependency types” between the impl and compat resolver providers, ensuring both the runtime type registries and the published APT reference docs list the same set of types with consistent semantics.
Changes:
- Add missing
fatjartype to the implDefaultTypeProvider. - Add missing
test-java-sourcetype to the compatDefaultTypeProviderand alignclasspath-processor/modular-processorordering across providers. - Fix and expand
dependency-types.apttables (add missing types and correctincludesDependencies/classifier entries).
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| impl/maven-impl/src/site/apt/dependency-types.apt | Updates the impl dependency-type reference table to include missing types and corrected attributes. |
| impl/maven-impl/src/main/java/org/apache/maven/impl/resolver/type/DefaultTypeProvider.java | Adds Type.FATJAR to the impl default type list. |
| compat/maven-resolver-provider/src/site/apt/dependency-types.apt | Updates the compat dependency-type reference table to match the provider behavior and include missing types. |
| compat/maven-resolver-provider/src/main/java/org/apache/maven/repository/internal/type/DefaultTypeProvider.java | Adds Type.TEST_JAVA_SOURCE and normalizes processor type ordering to match impl. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+52
to
+54
| *-----------------------+------------------+------------+-----------+-----------------------+-----------------------+ | ||
| | <<<test-java-source>>> * | <<<test-sources>>> | <<<jar>>> | java | | | | ||
| *-----------------------+------------------+------------+-----------+-----------------------+-----------------------+ |
Comment on lines
+52
to
+54
| *-----------------------+------------------+------------+-----------+-----------------------+-----------------------+ | ||
| | <<<test-java-source>>> * | <<<test-sources>>> | <<<jar>>> | java | | | | ||
| *-----------------------+------------------+------------+-----------+-----------------------+-----------------------+ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fatjartype to the implDefaultTypeProvidertest-java-sourcetype to the compatDefaultTypeProviderCLASSPATH_PROCESSOR/MODULAR_PROCESSORordering to be consistent between the two providersdependency-types.aptfiles: bogustestsclassifier onmodular-jar,classpath-jar, andfatjar; missingincludesDependencies=trueonfatjartest-java-source,processor,classpath-processor,modular-processorFollow-up to f9e66aa (fatjar handler for Maven 3) — this syncs the Maven 4 side.
Test plan
ArtifactHandlerTestpasses (validates legacy APT doc against handler manager)Claude Code on behalf of Guillaume Nodet
🤖 Generated with Claude Code