qcs6490: Fix sound card cannot be detected#9615
Conversation
It seems wcd938x driver module is not loaded automatically by default. Also use GITHUB_SOURCE to respect proxy settings for building.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughConfiguration updates to the Radxa Dragon Q6A board setup: enhanced audio module initialization in the initramfs by creating modules-load.d directory and configuring the WCD938X sound codec module, and refactored the ALSA UCM package URL to use a variable reference instead of a hardcoded URL. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Thanks for sending this in. Will take a look at it today with some other Q6A improvements |
| # Fix audio driver loading | ||
| mkdir -p "${destination}"/etc/modules-load.d | ||
| cat > "${destination}"/etc/modules-load.d/wcd938x.conf <<- EOT | ||
| snd-soc-wcd938x |
There was a problem hiding this comment.
I think same can be achieved with adding:
MODULES="snd-soc-wcd938x"
or
MODULES_CURRENT="...
It seems wcd938x driver module is not loaded automatically by default. Also use GITHUB_SOURCE to respect proxy settings for building.
You can refer to https://forum.armbian.com/topic/57121-latest-armbian-build-hdmi-audio-support-fix/ for more issue details.
Summary by CodeRabbit