Bump iOS simulator arm64 Helix queue to OSX.26 and centralize iOS-family queues#128448
Draft
matouskozak wants to merge 2 commits into
Draft
Bump iOS simulator arm64 Helix queue to OSX.26 and centralize iOS-family queues#128448matouskozak wants to merge 2 commits into
matouskozak wants to merge 2 commits into
Conversation
- Bump iOS/tvOS simulator and Mac Catalyst arm64 Helix queue from OSX.15.Arm64 to OSX.26.Arm64 (Tahoe). - Define the iOS/tvOS simulator, iOS device, and tvOS device queues as variables in eng/pipelines/helix-platforms.yml (public + internal), and switch the libraries and coreclr helix-queues-setup.yml call sites to consume them, so future updates only need to touch one file. - Drop the unused / incorrect helix_macos_ios_*_latest / _oldest variants that nobody referenced (the arm64-simulator entry was even pointing at an Amd64 queue). - Fix the helix_macos_arm64_latest comment that incorrectly described macOS 26 as 'Sequoia 15'; macOS 26 is Tahoe. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
|
Tagging subscribers to this area: @dotnet/runtime-infrastructure |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates Helix queue selection for the iOS/tvOS simulator, Mac Catalyst, and iOS/tvOS device platforms by centralizing their queue names into eng/pipelines/helix-platforms.yml and switching the queue-setup templates to consume those variables. It also bumps the arm64 iOS-family simulator host queue from OSX.15.Arm64(.Open) to OSX.26.Arm64(.Open).
Changes:
- Centralized iOS-family Helix queue names into new
helix_macos_ios_*variables ineng/pipelines/helix-platforms.yml(including public/internal variants). - Updated CoreCLR and Libraries helix queue setup templates to reference the centralized variables instead of inline queue strings.
- Updated macOS-arm64 “latest” comment to reflect macOS 26 (Tahoe).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| eng/pipelines/libraries/helix-queues-setup.yml | Replaces inline iOS-family queue strings with centralized helix_macos_ios_* variables. |
| eng/pipelines/helix-platforms.yml | Adds iOS-family queue variables (public/internal), removes unused iOS-family latest/oldest variants, and updates macOS 26 labeling. |
| eng/pipelines/coreclr/templates/helix-queues-setup.yml | Switches iOS-family queue selection to centralized variables (with public/internal branching). |
runtime-ioslike.yml, runtime-ioslikesimulator.yml, and runtime-maccatalyst.yml are standalone Azure Pipelines drivers typically triggered directly via '/azp run runtime-ioslikesimulator', not as part of the default runtime pipeline. They did not include eng/pipelines/helix-platforms.yml, so the centralized $(helix_macos_ios_*) variables introduced in the previous commit would fail to resolve when those pipelines are queued directly. Add the template include to each driver, matching the pattern used by runtime-cet.yml, runtime-extra-platforms.yml, runtime-sanitized.yml, and the coreclr stress pipelines. Originally proposed in dotnet#123083. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Member
Author
|
/azp run runtime-maccatalyst |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Content authored with assistance from GitHub Copilot.
Moves the iOS / tvOS simulator, Mac Catalyst, and iOS / tvOS device Helix queue references onto centralized variables in
eng/pipelines/helix-platforms.yml, and bumps the iOS-family arm64 simulator queue fromOSX.15.Arm64toOSX.26.Arm64(Tahoe) at the same time.Functional change
iossimulator_arm64/tvossimulator_arm64/maccatalyst_arm64OSX.15.Arm64.OpenOSX.26.Arm64.OpenOSX.15.Arm64OSX.26.Arm64iossimulator_x64/tvossimulator_x64/maccatalyst_x64OSX.15.Amd64.OpenOSX.15.Amd64.OpenOSX.15.Amd64OSX.15.Amd64ios_arm64deviceosx.15.amd64.iphone.openOSX.15.Amd64.Iphone.Openosx.15.amd64.iphoneOSX.15.Amd64.Iphonetvos_arm64deviceosx.15.amd64.appletv.openOSX.15.Amd64.AppleTV.Openosx.15.amd64.appletvOSX.15.Amd64.AppleTVOnly the arm64 simulator row is a behavioral change. Everything else is a same-queue replacement (Helix queue names are case-insensitive, so the case-only changes are no-ops).
OSX.26.Arm64(.Open)is already declared inhelix-platforms.ymlas the macOS-arm64latestqueue and is in use elsewhere, so no dnceng coordination is required.Centralization cleanup
eng/pipelines/helix-platforms.ymlwas added in #120817 specifically to centralize Helix queue names, but the iOS-family entries were never wired up at the call sites and the values there had drifted/were buggy. This PR finishes that work:helix_macos_ios_simulator_arm64/_internalhelix_macos_ios_simulator_x64/_internalhelix_macos_ios_device/_internalhelix_macos_tvos_device/_internaleng/pipelines/libraries/helix-queues-setup.ymlandeng/pipelines/coreclr/templates/helix-queues-setup.ymlto consume them, so future bumps only touchhelix-platforms.yml._latest/_oldestvariants — the iOS family only has a single queue per (platform, project) combination, so no slot picker is needed. The pre-existing_latestarm64-simulator entry was also pointing at an Amd64 queue, so it was buggy as well as unused.helix_macos_arm64_latestcomment that described macOS 26 as "Sequoia 15"; macOS 26 is Tahoe.