chore(alerts): Remove AlertRuleSerializer#116052
Conversation
github-actions
Bot
added
the
Scope: Backend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| re_path( | ||
| r"^debug/mail/sso-unlinked/no-password/$", DebugSsoUnlinkedNoPasswordEmailView.as_view() | ||
| ), | ||
| re_path(r"^debug/mail/incident-trigger/$", DebugIncidentTriggerEmailView.as_view()), |
There was a problem hiding this comment.
Stale dropdown option references removed debug email route
Low Severity
The debug mail preview template still has an <option value="mail/incident-trigger">Metric Alert Trigger</option> entry, but the corresponding URL route (debug/mail/incident-trigger/) was removed from debug_urls.py and the view DebugIncidentTriggerEmailView was deleted. Selecting "Metric Alert Trigger" from the dropdown will navigate to a nonexistent URL and result in a 404.
Reviewed by Cursor Bugbot for commit 2577ce7. Configure here.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
There are 3 total unresolved issues (including 1 from previous review).
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit e1f20a2. Configure here.
|
Removing getsentry usage in https://github.com/getsentry/getsentry/pull/20391 |
ceorourke
force-pushed
the
ceorourke/rm-alert-rule-serializer
branch
from
26a051e to
a8f75d6
Compare
1 participant
Remove the
AlertRuleSerializerandIncidentSerializer(the actual serializer serializers, as opposed to the validator serializers) as they are no longer in use - only places they were "used" is for API responses (they're unpublished) and a debug email view. A follow up will clean up the responses e.g.AlertRuleSerializerResponseas there are many imports and this PR is already large.