-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Improve responsive styling for integration category chips #7727
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
shteypandey28-hue
wants to merge
4
commits into
layer5io:master
Choose a base branch
from
shteypandey28-hue:fix/integration-category-chip-styling
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+205
−126
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
b62d11c
Improve responsive styling for integration category chips
shteypandey28-hue 934ccc4
Merge branch 'master' into fix/integration-category-chip-styling
saurabhraghuvanshii 77e6132
style: refine mobile scrolling and breathing room for category chips
shteypandey28-hue 3a915a1
Bump sistent v0.21.12 dependencies
Rajesh-Nagarajan-11 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The refactor looks good overall and the responsiveness/accessibility improvements are nice additions. Replacing the slider with a flex-based layout also simplifies the UI structure.
One small thing: the PR description mentions removing the react-slick dependency, but I can still see react-slick present in package.json. Looks like the usage was removed from this component, but the dependency itself may still need cleanup if it's no longer used elsewhere.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the feedback! I've just updated the branch and pushed a couple of responsive mobile UX refinements:
Decreased Cramping: Slightly increased the gap between chips (gap: 0.625rem) and updated padding to give the chips much better breathing room on smaller viewports.
Refined Scroll Insets: Expanded the mobile scroll wrapper to the screen boundaries using negative horizontal margins matching a 1.5rem inner padding. This ensures the first and last chips don't touch the screen edge abruptly, and aligns the horizontal scroll perfectly with the main content container.
Smooth Balanced Fades: Added a z-indexed, gradient left-fade indicator (&::before) matching the right-fade (&::after). Now, as you scroll past the first chip, the content fades beautifully into both screen boundaries, resolving the abrupt clipping feel.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On mobile view, category chips are still getting hidden off-screen right now.
