Fix entitlements rendering incorrectly#317857
Merged
Merged
Conversation
anthonykim1
approved these changes
May 21, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Updates chat quota parsing to correctly preserve and surface quota snapshot values that are valid finite numbers but not safe integers, which should address incorrect rendering of entitlement/quota values in the chat UI.
Changes:
- Loosens validation for
entitlementandquotaRemainingin quota snapshots fromNumber.isSafeIntegertoNumber.isFinite. - Ensures non-integer (fractional) quota values can flow through parsing instead of being dropped as
undefined.
Show a summary per file
| File | Description |
|---|---|
| src/vs/workbench/services/chat/common/chatEntitlementService.ts | Adjusts quota snapshot numeric validation to accept finite non-integer values for entitlement/quota remaining. |
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.