Change symlink verification to avoid redirection guard policy#6239
Merged
Conversation
florelis
previously approved these changes
May 20, 2026
yao-msft
reviewed
May 20, 2026
yao-msft
approved these changes
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📖 Description
Rather than comparing the symlink and desired target through
weakly_canonical, this change checks that the symlink is pointing to the target via string comparison. This avoids "resolving" the symlink and the redirection guard policy.🔗 References
Fixes #6211
🔍 Validation
Enabled the redirection guard for the unit test process; test started failing as expected.
Product fix resolved test failure; added additional validations to test.
📋 Issue Type
Microsoft Reviewers: Open in CodeFlow