feat(cli): pass skip testing flag to application schematic#3448
Open
yudin-s wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
The v12
nest new --skip-testsflag passesspec: falseto the application schematic. That skips spec files, but it does not give the schematic enough information to skip the full testing scaffold.Issue Number: Refs #2575
What is the new behavior?
When
--skip-testsis enabled, the new command now passes bothspec: falseandskipTesting: trueto the application schematic. This preserves the existing spec-file behavior while allowing the schematic to omit test files, Jest configuration, testing scripts, and testing-related dependencies.This pairs with nestjs/schematics#2354.
Does this PR introduce a breaking change?
Other information
Validated with:
npm run lintcompleted with one existing warning inlib/runners/runner.factory.tsand no errors.