chore: env management overhaul#9408
Draft
AdityaHegde wants to merge 8 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have multiple places where we read .env and assign variables for secrets. This leads to fragmented code especially with the new ducklake form changes.
Adding a service to manage env variables.
EnvStoremanages the full list of variables. Has hooks for getter and setter so that in future we can separate the file write and admin API calls.EnvEditSessionmanages the variables in flight during an edit. Managed which variables are assigned so that new env vars that come during the add data process is not overwritten.compileConnectorYAML. This makes things like ducklake utils to not worry about env, just focus on attach.Checklist: