fix: close annotation file handle via context manager#484
Open
tempoo04 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes a resource leak in Project._annotation_params() where annotation_path was opened twice — once via a context
manager that did nothing, and again with a bare open() call whose handle was never closed.
Before:
After:
Related Issue(s): N/A
Type of Change
Testing
Test details:
Manually verified annotation upload flow reads file content correctly with the fixed handle. No behavioral change —
fix only affects resource cleanup.
Checklist
Additional Context
File descriptor leak only matters under high-volume upload loops or on systems with low fd limits, but the fix also
removes the redundant open() call making the intent clearer.