fix: raise ValueError with context on malformed signed URL#485
Open
tempoo04 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes a brittle URL parsing pattern in InferenceModel.predict_video() where splitting the signed URL to extract the
expiry value would raise a bare IndexError with no context if the URL format ever changes or is unexpected.
Before:
After:
Related Issue(s): N/A
Type of Change
Testing
Test details:
No behavioral change for valid URLs. Verified the error path raises ValueError with a descriptive message instead of a
bare IndexError.
Checklist
Additional Context
A bare IndexError gives no indication of what failed or what the URL looked like. The fix wraps the parse in a
try/except and re-raises as ValueError with the offending URL in the message, making debugging significantly faster.